Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of uninitialized value in sdp4() #48

Closed
bjorgan opened this issue Dec 26, 2015 · 2 comments
Closed

Use of uninitialized value in sdp4() #48

bjorgan opened this issue Dec 26, 2015 · 2 comments
Labels
bug patch number bump
Milestone
2.0.0

Comments

@bjorgan
Copy link
Member

bjorgan commented Dec 26, 2015

In src/sdp4.c, line 326:

m->preep is used in a conditional statement before it is initialized. The same thing is present in original code from spacetrack report # 3. Not sure what it should be initialized to in advance, possibly 0.
@bjorgan
Copy link
Member Author

bjorgan commented Dec 27, 2015

PREEP is compared against the number of days since Jan 1 12:00 UTC year 1900 (or something close). This will never become 0 in any meaningful way, so it should be safe to initialize PREEP to 0.

@bjorgan
Copy link
Member Author

bjorgan commented Dec 30, 2015

Fixed in commit 7adc23e.

@bjorgan bjorgan closed this as completed Dec 30, 2015
@ryeng ryeng added this to the 2.0.0 milestone Nov 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug patch number bump
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
2 participants
@ryeng @bjorgan