Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added viewcode extension to sphinx to view source code in documentation [fixing #171] #184

Merged
merged 3 commits into from
Mar 14, 2023

Conversation

ecignoni
Copy link
Contributor

@ecignoni ecignoni commented Mar 10, 2023

fixing #171


📚 Documentation preview 📚: https://equistore--184.org.readthedocs.build/en/184/

@agoscinski agoscinski self-requested a review March 10, 2023 10:38
@agoscinski
Copy link
Contributor

agoscinski commented Mar 14, 2023

found this issue with a solution readthedocs/readthedocs.org#2139 (comment)

I would try to change this line https://github.com/ecignoni/equistore/blob/3c32cc78edbecaacb4a6103ce5ea53838d1cd144/docs/src/conf.py#L12 to

sys.path.append(os.path.join(ROOT, "python", "src", "equistore"))

EDIT: reflecting on this, we are already adding the src folder, so it should not be the fix. Also the problem is not that the link is missing, but that the doc is not shown

@Luthaf
Copy link
Member

Luthaf commented Mar 14, 2023

Seems to work fine now!

@agoscinski
Copy link
Contributor

Looks good. Thanks for the nice fix!

@agoscinski agoscinski merged commit 901fe07 into metatensor:master Mar 14, 2023
@agoscinski agoscinski mentioned this pull request Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants