-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split equistore in a C-API core crate and a Rust wrapper #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Here is a pre-built version of the code in this pull request: wheels.zip, you can install it locally by unzipping |
Luthaf
force-pushed
the
split-c-api
branch
6 times, most recently
from
December 9, 2022 12:17
82c6aae
to
70a5d10
Compare
Luthaf
force-pushed
the
split-c-api
branch
12 times, most recently
from
January 10, 2023 16:05
1243102
to
5cf0395
Compare
Closed
Luthaf
force-pushed
the
split-c-api
branch
2 times, most recently
from
January 25, 2023 18:22
b15c890
to
684d97b
Compare
Luthaf
force-pushed
the
split-c-api
branch
3 times, most recently
from
February 23, 2023 14:38
d39d4bf
to
975166e
Compare
Luthaf
force-pushed
the
split-c-api
branch
2 times, most recently
from
February 28, 2023 16:05
4d52408
to
546123c
Compare
And merged! 🚀 |
This was referenced Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #102
Closes #140
This is phase I of making equistore compatible with TorchScript, by having a separate C API we can load the code from a single shared library regardless if we are using it from Python/Torch/rascaline/…
be placed
built (it had multiple optional feature before)
Python bindings explicitly manage the lifetime of array using
This is now Make Tensormap immutable #86Py_IncRef
andPy_DecRef
we no longer have to explicitly keep references to arrays around, thissimplifies the code quite a bit
Still TODO:
📚 Documentation preview 📚: https://equistore--85.org.readthedocs.build/en/85/