Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

Fork pybind11 so CyberReboot owns a copy #2

Closed
AlexanderTitus opened this issue Nov 6, 2017 · 2 comments
Closed

Fork pybind11 so CyberReboot owns a copy #2

AlexanderTitus opened this issue Nov 6, 2017 · 2 comments

Comments

@AlexanderTitus
Copy link
Contributor

AlexanderTitus commented Nov 6, 2017

The pySEAL docker image currently clones a public repository for pybind11
git clone https://github.com/pybind/pybind11.git

I would like to request that CyberReboot forks pybind11 so we can point the docker image to our own hosted repo to prevent our build from breaking if they update the software without our knowledge.

Thanks!

@cglewis
Copy link
Member

cglewis commented Nov 6, 2017

@AlexanderTitus why not do a git checkout to the specific commit that works for what you need, that way we don't have to maintain yet another fork?

@AlexanderTitus
Copy link
Contributor Author

@cglewis I'll do that.

mbrg added a commit to mbrg/sealed that referenced this issue Oct 23, 2019
* Travis w/o Docker, using setup script

* Update root dir

* Fix setup root and sudo

* Reformat script to .travis.yml instead of setup.sh

* Fix SEAL location

* Remove cleanup, reorder to install and after_success parts

* Added caching

* Re-added various Python versions

* Test as part of script section

* Conditional build for SEAL and Pybind11 to support caching

* Fix multiple statements within if-fi bug
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants