Skip to content
This repository has been archived by the owner on Apr 21, 2022. It is now read-only.

docker.cmd.test assumes an image name #18

Open
bfirsh opened this issue Feb 7, 2017 · 2 comments
Open

docker.cmd.test assumes an image name #18

bfirsh opened this issue Feb 7, 2017 · 2 comments

Comments

@bfirsh
Copy link

bfirsh commented Feb 7, 2017

The docker.cmd.test label requires you to pass an absolute image name. The image being tested might be under a different name or tag.

A much more useful label for me would be a path to an executable inside the container to run. This would be portable across runtimes, and allow the consumer of the label to easily pass their own options, etc.

@lizrice
Copy link
Contributor

lizrice commented Mar 7, 2017

I like the idea of being able to specify these cmd.* labels in a runtime-portable way. Would it work to have cmd, cmd.test, cmd.help etc that just have the path to the executable (and no options)? If you need to pass in particular options you'd need to specify docker.cmd.*, but if no options are required (or the label consumer knows what they are somehow) you could just use a vanilla cmd.*. Wdyt?

@bfirsh
Copy link
Author

bfirsh commented Mar 15, 2017

That sounds like it'd work!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants