Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double quote variable values/shell expansion #6

Closed
curiositycasualty opened this issue Jun 3, 2020 · 0 comments · Fixed by #9
Closed

Double quote variable values/shell expansion #6

curiositycasualty opened this issue Jun 3, 2020 · 0 comments · Fixed by #9

Comments

@curiositycasualty
Copy link

gitHubActions/branch-release/branch_release.sh

Line 26 in 55b8366

TAG=$(echo "$GITHUB_REF" | sed -e 's/refs\/tags\///')

shellcheck will also yell at you for this, but I personally find it helps clarify where this type of expansion is happening.

This can be written as:

TAG="$(echo "$GITHUB_REF" | sed -e 's/refs\/tags\///')"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cleanup action scripts LabKey/gitHubActions
1 participant
@curiositycasualty