Skip to content

Commit

Permalink
feat: add aliased key of session_name (#1395)
Browse files Browse the repository at this point in the history
Co-authored-by: Kyujin Cho <kyujin.cho@lablup.com>
  • Loading branch information
pderer and kyujin-cho committed Jul 17, 2023
1 parent efe3b19 commit 1d7f020
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
1 change: 1 addition & 0 deletions changes/1395.fix.md
@@ -0,0 +1 @@
Add `session_name` to aliased key of `session_name`
2 changes: 1 addition & 1 deletion src/ai/backend/manager/api/service.py
Expand Up @@ -163,7 +163,7 @@ async def get_info(request: web.Request) -> web.Response:
@check_api_params(
t.Dict(
{
tx.AliasedKey(["name", "clientSessionToken"])
tx.AliasedKey(["name", "service_name", "clientSessionToken"])
>> "service_name": t.Regexp(r"^(?=.{4,64}$)\w[\w.-]*\w$", re.ASCII),
tx.AliasedKey(["desired_session_count", "desiredSessionCount"]): t.Int,
tx.AliasedKey(["image", "lang"]): t.String,
Expand Down
6 changes: 3 additions & 3 deletions src/ai/backend/manager/api/session.py
Expand Up @@ -378,7 +378,7 @@ async def _create(request: web.Request, params: dict[str, Any]) -> web.Response:
t.Dict(
{
tx.AliasedKey(["template_id", "templateId"]): t.Null | tx.UUID,
tx.AliasedKey(["name", "clientSessionToken"], default=undefined)
tx.AliasedKey(["name", "session_name", "clientSessionToken"], default=undefined)
>> "session_name": UndefChecker | t.Regexp(r"^(?=.{4,64}$)\w[\w.-]*\w$", re.ASCII),
tx.AliasedKey(["image", "lang"], default=undefined): UndefChecker | t.Null | t.String,
tx.AliasedKey(["arch", "architecture"], default=DEFAULT_IMAGE_ARCH)
Expand Down Expand Up @@ -564,7 +564,7 @@ async def create_from_template(request: web.Request, params: dict[str, Any]) ->
@check_api_params(
t.Dict(
{
tx.AliasedKey(["name", "clientSessionToken"])
tx.AliasedKey(["name", "session_name", "clientSessionToken"])
>> "session_name": t.Regexp(r"^(?=.{4,64}$)\w[\w.-]*\w$", re.ASCII),
tx.AliasedKey(["image", "lang"]): t.String,
tx.AliasedKey(["arch", "architecture"], default=DEFAULT_IMAGE_ARCH)
Expand Down Expand Up @@ -1062,7 +1062,7 @@ async def report_stats(root_ctx: RootContext, interval: float) -> None:
@check_api_params(
t.Dict(
{
tx.AliasedKey(["name", "clientSessionToken"])
tx.AliasedKey(["name", "session_name", "clientSessionToken"])
>> "session_name": t.Regexp(r"^(?=.{4,64}$)\w[\w.-]*\w$", re.ASCII),
}
),
Expand Down

0 comments on commit 1d7f020

Please sign in to comment.