feat: add aliased key of session_name
#1395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pderer
added
type:bug
|
|
kyujin-cho
requested changes
Jul 17, 2023
pderer
changed the title
session_name
pderer
added
type:feature
Co-authored-by: Kyujin Cho <kyujin.cho@lablup.com>
kyujin-cho
added a commit
that referenced
this pull request
Jul 17, 2023
Co-authored-by: Kyujin Cho <kyujin.cho@lablup.com> Backported-from: main Backported-to: 23.03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When request creating session API, response notes that "session_name" is required.
but when request parameter contain "session_name", response notes that "session_name" is not allowed key.
To resolve this ambiguity, session_name is added to the aliased key of session_name.
So, request contained "session_name" is allowed.