Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid checking max_vfolder_count #1397

Merged
merged 7 commits into from
Aug 29, 2023
Merged

fix: avoid checking max_vfolder_count #1397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f604749
fix: avoid check "max_vfolder_count"
Jul 14, 2023
afa51e2
doc: add news fragment
Jul 14, 2023
84c9e32
docs: Rename the news fragment with the PR number
pderer Jul 14, 2023
67619bb
fix: check "max_vfolder_count" in creating vfolder
Jul 14, 2023
01ebfeb
Merge branch 'main' into fix/avoid-using-keypair-resource-policy-max-…
achimnol Aug 29, 2023
ca1d7e0
doc: Rephrase news fragment [skip ci]
achimnol Aug 29, 2023
14f8185
Merge branch 'main' into fix/avoid-using-keypair-resource-policy-max-…
achimnol Aug 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions changes/1397.fix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Allow projcet vfolder creation regardless of the user (keypair) vfolder count limit
2 changes: 1 addition & 1 deletion src/ai/backend/manager/api/vfolder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,7 +459,7 @@ async def create(request: web.Request, params: Any) -> web.Response:
if keypair_resource_policy["max_vfolder_count"] > 0:
query = sa.select([sa.func.count()]).where(vfolders.c.user == user_uuid)
result = await conn.scalar(query)
if result >= keypair_resource_policy["max_vfolder_count"]:
if result >= keypair_resource_policy["max_vfolder_count"] and ownership_type == "user":
raise InvalidAPIParameters("You cannot create more vfolders.")

# DEPRECATED: Limit vfolder size quota if it is larger than max_vfolder_size of the resource policy.
Expand Down