Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add max_pending_session_count field to keypair_resource_policy GQL schema #2013

Merged
merged 7 commits into from May 13, 2024
Merged

chore: Add max_pending_session_count field to keypair_resource_policy GQL schema #2013

merged 7 commits into from May 13, 2024

Conversation

fregataa
Copy link
Contributor

@fregataa fregataa commented Apr 9, 2024 •
edited

follow-up #1226

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • API server-client counterparts (e.g., manager API -> client SDK)
  • Documentation
    • Contents in the docs directory
    • docstrings in public interfaces and type annotations

@fregataa fregataa added this to the 24.03 milestone Apr 9, 2024
@fregataa fregataa self-assigned this Apr 9, 2024
@github-actions github-actions bot added comp:manager Related to Manager component size:S 10~30 LoC labels Apr 9, 2024
@fregataa fregataa requested a review from agatha197 April 9, 2024 10:23
@fregataa fregataa marked this pull request as draft April 9, 2024 10:23
@fregataa fregataa changed the title chore: Add 'max_pending_session_count' field to keypair_resource_policy GQL schema chore: Add max_pending_session_count field to keypair_resource_policy GQL schema May 13, 2024
@fregataa fregataa marked this pull request as ready for review May 13, 2024 05:52
@github-actions github-actions bot added size:M 30~100 LoC and removed size:S 10~30 LoC labels May 13, 2024
agatha197
agatha197 approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@agatha197 agatha197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fregataa fregataa merged commit 8241fd0 into main May 13, 2024
29 checks passed
@fregataa fregataa deleted the chore/max-pending-session-count-gql branch May 13, 2024 07:32
lablup-octodog pushed a commit that referenced this pull request May 13, 2024
@fregataa
chore: Add field to keypair_resource_policy GQL schema (#2013)
7294387 
Backported-from: main (24.09)
Backported-to: 24.03
Backport-of: 2013
@lablup-octodog lablup-octodog mentioned this pull request May 13, 2024
Merged
fregataa added a commit that referenced this pull request May 13, 2024
@fregataa
chore: Add max_pending_session_count field to keypair_resource_poli…
0ad399b 
…cy GQL schema (#2013)

Backported-from: main (24.09)
Backported-to: 24.03
@agatha197 agatha197 mentioned this pull request May 15, 2024
Open
7 tasks
Yaminyam pushed a commit that referenced this pull request May 17, 2024
@lablup-octodog
chore: Add field to keypair_resource_policy GQL schema (#2013) (#2139)
c9cb953 
Backported-from: main (24.09)
Backported-to: 24.03
Backport-of: 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agatha197 agatha197 agatha197 approved these changes

Assignees

@fregataa fregataa

Labels
comp:manager Related to Manager component size:M 30~100 LoC
Projects
None yet
Milestone
24.03
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fregataa @agatha197