feat: Add missing fields of keypair resource policy #2146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @agatha197 and the rest of your teammates on |
agatha197
changed the title
max_pending_session_count and max_pending_session_resource_slots fields to keypair_resource_policy cli
agatha197
force-pushed
the
feature/add-max_pending_session_count-to-client
branch
from
6203cb2
to
5b7729a
Compare
fregataa
approved these changes
May 15, 2024
agatha197
force-pushed
the
feature/add-max_pending_session_count-to-client
branch
from
5b7729a
to
91b9288
Compare
github-actions
bot
added
comp:manager
agatha197
force-pushed
the
feature/add-max_pending_session_count-to-client
branch
from
91b9288
to
147ba34
Compare
agatha197
changed the title
agatha197
changed the title
…rce_slots` fields to keypair_resource_policy
agatha197
force-pushed
the
feature/add-max_pending_session_count-to-client
branch
from
606c7f7
to
0e43a26
Compare
agatha197
force-pushed
the
feature/add-max_pending_session_count-to-client
branch
from
0e43a26
to
09ba91a
Compare
I added more missing options such as |
lablup-octodog
pushed a commit
that referenced
this pull request
May 28, 2024
Co-authored-by: Kyujin Cho <kyujin.cho@lablup.com> Backported-from: main (24.09) Backported-to: 24.03 Backport-of: 2146
|
Backport to 24.09 is failed. Please backport manually. |
lablup-octodog
added a commit
that referenced
this pull request
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follows #2013
TL;DR
Added missing fields of
keypair_resource_policysuch asmax_pending_session_count,max_pending_session_resource_slots,max_session_lifetime, andmax_concurrent_sftp_sessions.What changed?
max_pending_session_countandmax_pending_session_resource_slotsto the keypair resource policy CLI commands and functions.max_concurrent_sftp_sessionsis added toKeypairResourcePolicythat is missed in feat: concurrency limit for system sessions #1299.How to test?
Ensure that the new options can be set and updated successfully in the keypair resource policy.
Why make this change?
The change introduces new flexibility by allowing users to set maximum pending sessions and resource slots for pending sessions in the keypair resource policy.
Checklist: (if applicable)
ai.backend.testdocsdirectory