Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: impl vfolder RBAC APIs #2137

Draft
wants to merge 25 commits into
base: topic/06-11-chore_add_vfolders.domain_name_and_vfolder_permissions.id
Choose a base branch
from

Conversation

fregataa
Copy link
Contributor

@fregataa fregataa commented May 12, 2024

implement basic functions and APIs for RBAC design

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Update of end-to-end CLI integration tests in ai.backend.test
  • API server-client counterparts (e.g., manager API -> client SDK)
  • Test case(s) to:
    • Demonstrate the difference of before/after
    • Demonstrate the flow of abstract/conceptual models with a concrete implementation
  • Documentation
    • Contents in the docs directory
    • docstrings in public interfaces and type annotations

📚 Documentation preview 📚: https://sorna--2137.org.readthedocs.build/en/2137/


📚 Documentation preview 📚: https://sorna-ko--2137.org.readthedocs.build/ko/2137/

Copy link

graphite-app bot commented May 12, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added comp:manager Related to Manager component require:db-migration Automatically set when alembic migrations are added or updated size:XL 500~ LoC labels May 12, 2024
Copy link
Contributor Author

fregataa commented May 12, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fregataa and the rest of your teammates on Graphite Graphite

@fregataa fregataa force-pushed the topic/05-12-refactor_impl_vfolder_rbac_apis branch 3 times, most recently from bc7738d to dcb2e94 Compare May 13, 2024 11:09
@fregataa fregataa added this to the 24.09 milestone May 13, 2024
@fregataa fregataa force-pushed the topic/05-12-refactor_impl_vfolder_rbac_apis branch 2 times, most recently from 22d8e97 to 5827fe9 Compare May 13, 2024 13:15
@github-actions github-actions bot added the area:docs Documentations label May 13, 2024
@fregataa fregataa force-pushed the topic/05-12-refactor_impl_vfolder_rbac_apis branch 5 times, most recently from 4114bb0 to ae938f0 Compare May 14, 2024 12:58
@fregataa fregataa requested review from kyujin-cho and achimnol and removed request for kyujin-cho May 14, 2024 13:21
@fregataa fregataa force-pushed the topic/05-12-refactor_impl_vfolder_rbac_apis branch from ae938f0 to 835a2a2 Compare May 14, 2024 14:53
@fregataa fregataa added the skip:changelog Make the action workflow to skip towncrier check label May 17, 2024
@fregataa fregataa marked this pull request as ready for review May 17, 2024 14:17
@fregataa fregataa force-pushed the topic/05-12-refactor_impl_vfolder_rbac_apis branch from 835a2a2 to fe8b91f Compare May 17, 2024 14:18
@fregataa fregataa marked this pull request as draft May 29, 2024 00:53
@fregataa fregataa force-pushed the topic/05-12-refactor_impl_vfolder_rbac_apis branch 2 times, most recently from 17feffd to 5b21bcc Compare May 30, 2024 06:37
@fregataa fregataa removed the require:db-migration Automatically set when alembic migrations are added or updated label Jun 11, 2024
@fregataa fregataa force-pushed the topic/05-12-refactor_impl_vfolder_rbac_apis branch from 44013ff to fe3969e Compare June 11, 2024 08:04
@fregataa fregataa force-pushed the topic/06-11-chore_add_vfolders.domain_name_and_vfolder_permissions.id branch from 5274c56 to 4161693 Compare June 11, 2024 11:58
@fregataa fregataa force-pushed the topic/05-12-refactor_impl_vfolder_rbac_apis branch from fe3969e to 7c7d36e Compare June 11, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:docs Documentations comp:manager Related to Manager component size:XL 500~ LoC skip:changelog Make the action workflow to skip towncrier check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant