Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows support #70

Open
7 of 13 tasks
orlandini opened this issue Mar 27, 2021 · 6 comments
Open
7 of 13 tasks

Windows support #70

orlandini opened this issue Mar 27, 2021 · 6 comments
Assignees
Labels

Comments

@orlandini
Copy link
Member

orlandini commented Mar 27, 2021

Since PR #67 there is no official Windows support on the development branch.

The following list consists of our current objectives currently being implemented on the branch windows-port

  • Build NeoPZ Library
  • Build NeoPZ Library + MKL
  • Build NeoPZ Library + LAPACK (without MKL)
  • Build NeoPZ Library + Boost
  • Run UnitTests
  • Pass UnitTests
  • Create UnitTests workflow for Windows
  • Build NeoPZ Library + log4cxx
  • Install NeoPZ Library
  • Find NeoPZ Library from External Projects
  • Building External Projects
  • Running External Projects
  • Add on README.md that we now require BOOST_VERSION >= 1.64
    Please comment if there are any other relevant tasks that should be included in this list.
@orlandini
Copy link
Member Author

I've written down here my procedure for setting up the environment on windows systems. I have little experience with it, so I won't vouch 100% for it, but it is working on my machine (windows 10 fresh install)

@pedrolimasi
Copy link
Member

Your gist has a command which is not available from Visual Studio 2019.

  1. I made it work running CMake from git bash. In neopz-src-dir/build, I ran2:
"C:/Program Files/CMake/bin/cmake.exe" --config Release -G"Visual Studio 15 Win64" ..

It is super important to set the generator correctly to ensure that we will build to a 64bit target. This is not the default.

Although CMake lists it as a generator for me, using Visual Studio 15 Win64 gives me an error.

CMake Error at CMakeLists.txt:8 (project):
  Generator

    Visual Studio 15 2017 Win64

  could not find any instance of Visual Studio.

-- Configuring incomplete, errors occurred!

@orlandini
Copy link
Member Author

That's because you have the 2019 version, @pedrolima92. Write some gibberish on the generator name and CMake will spit out a list of names for you, and then you just put in the right one for the 2019 version.

@gustavobat
Copy link
Member

gustavobat commented Mar 29, 2021

@pedrolima92 alternatively, you can use cmake -DCMAKE_GENERATOR_PLATFORM=x64 .. or even cmake .. -A x64 instead of specifying the complete name of the x64 generator. Could you please check if this works on your machine as well?

@pedrolimasi
Copy link
Member

That worked, @gustavobat, thanks. Actually that worked as in "it convinced me that what I had before trying Fran's gist was already working. The error I was getting wasn't actually due to an attempt to link MKL-32bit"... So I still have to figure that one out.

I guess what I'm trying to get at is, that line in the gist seems only necessary to Visual Studio 15 2017

@orlandini
Copy link
Member Author

orlandini commented Mar 31, 2021

@pedrolima92 specifying that the target's architecture is 64bits is important regardless of which Visual Studio version you are using. If you had not had issues with finding TBB you would surely have faced the linking errors that I've mentioned.

How you specify the architecture is a whole other story, and I agree that @gustavobat provided a more general solution.

Anyway, I have updated the gist since then.

@orlandini orlandini changed the title Windows support on development branch Windows support Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants