-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Button size—'Yes' 'No' 'Maybe' #92
Comments
@lacabra I would like to work on this issue. Please assign it to me. |
@lacabra Thank you for assigning this issue to me. I am unable to access the Zeplin link. It displays a message "You are not invited to the project". Could you please help me out with accessing it or provide a bit more information on this issue. |
@rachita19082 Thanks for pointing out the broken link. The main website was upgraded earlier this week, when the link broke. Use this one instead https://game.projectconnect.world (I've updated the link on the repo description; and yes, you are welcome to play the game 🙃 ). I'm working on the Zeplin link... |
Zeplin screenshots: This is what the distribution and relative size of the buttons should look like (don't mind the grey color of the Next button at the bottom): Here's some specs about sizes, but bear in mind that in Zeplin they are set in absolute terms, and in order to be responsive, they have to be set in relative units or percentages: |
Thank you, I will start working on it and get in touch if I have any further doubts. |
@lacabra I have made the required change in the code. However, while committing the change, I noticed some modifications in the package-lock.json file even though I did not make any changes. Please let me know what could have caused these changes and if I should keep them or remove them while committing. |
@lacabra I also wanted to know if I should change the border-radius to 18.5 px as given in the Zeplin screenshot and make the button text "Maybe" instead of "Unsure". |
Thanks @rachita19082:
|
Thanks @rachita19082, I have approved the deployment, and I will review the pull request later today or tomorrow, thank you |
@lacabra Okay, thank you. |
Right now the button sizes for the 3 options ('Yes' 'No' 'Maybe') feels small, especially while playing the game in mobile site.
Can the sizes be increased as per Zeplin: https://zpl.io/2vE7pmY
Ideally if the 3 buttons can span across the width of the map image, with paddings between each other.
The text was updated successfully, but these errors were encountered: