Added support for configuration by environment variable #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itzg
reviewed
Apr 13, 2020
|
|
||
| | Variable | Description | Accepted values | Default value | | ||
| |:--------:|:-----------:|:---------------:|:-------------:| | ||
| | RWA_ENV | Enables configuration by environment variables | TRUE / FALSE | FALSE | |
There was a problem hiding this comment.
I have pre-enabled this setting here
https://github.com/itzg/docker-rcon-web-admin/blob/master/Dockerfile#L23
since environment variable driven configuration will be perfect for containers. When this PR is merged I will link to this README section from the Options section of the image.
|
@lacaulac could you enable issues on this repo please? |
ChipWolf
force-pushed
the
master
branch
3 times, most recently
from
d7ee282
to
43ded94
Compare
|
@ChipWolf Done! Sorry for the delay. Nice work, I really like how you've changed the README file too! |
|
And docs are linked: https://github.com/itzg/docker-rcon-web-admin#environment-variables |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a functional first pass, with a readme rewrite