Ladybug Geometry 'dictutil' converter function #311
Conversation
New "dictutil" for Ladybug Geometry, similar to the existing Honeybee "dictutil". Converts any input dict into a new Ladybug Object.
Add files via upload
Tests for new Ladybug Geometry dictutil converter function
Add files via upload
|
|
Update to PR #311 - revised "test/dictutil_test.py" import statements, updated names (files, function) as per comments. Added new tests for completeness. Verified that all tests pass.
There was a problem hiding this comment.
Sorry that it took me a while to review this, @PH-Tools . There were just a few styling issues that would be good to fix before we merge. Once they're addressed we can merge.
|
Great - thanks @chriswmackey ! I appreciate the detailed notes - apologies for the mistakes there. I have updated everything as per your comments and verified that all tests are still passing. I've revised this commit with the new code. Let me know if there is anything else though or if I did anything incorrectly with the update? Happy to revise. thanks! |
|
🎉 This PR is included in version 1.23.13 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
Great! thanks for helping me get this PR sorted. Glad it worked. |
|
NP. Welcome to the contributor's list! |
Adds a new converter function to ladybug_geometry. Similar to the existing 'dictutil' for Honeybee. Takes in a dict and converts to back Ladybug Geometry Object (reverses the .to_dict method). Includes unit tests.