Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameter 'e' (exchange) to method get_historical_price() #13

Closed
sebastianhaberey opened this issue May 6, 2018 · 1 comment
Closed

Comments

@sebastianhaberey
Copy link

First off, thanks for this convenient library 👍

If I had one wish it would be to add the parameter 'e' to the method get_historical_price(). It is mentioned on the cryptocompare.com website and enables the caller to select a specific exchange as source for the historical price instead of the default cryptocompare.com aggregate CCCAGG.

@lagerfeuer
Copy link
Owner

Thank you for your input, this is now added with 9ccc781.
If you want more features, feel free to add them yourself and open a pull request or open another issue, bigger changes might take a while because of my class load.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants