Refactor XML helper code and move some to ContainerUtils #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify some of the longer names, and use lowerCamelCase.
The required version defaults to "", which means no required version. Version check is skipped. This makes code more consistent with other file parsing code, which often does include a version check. Hopefully this will lead to more code re-use.
If the default sectionName of "" is used, then the XML document's root element will be used, whatever that happens to be named.
If there are no optional names, it may be simpler to compose the component functions directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: #797
Prep-work for updating the
SpriteXML loading code. This cleans up some of theConfigurationXML loading code, preparing it for re-use by theSpriteclass. Added is the ability to version check the root element. Some helper code needed for common error reporting tasks was split and partially moved toContainerUtils.h. Ability to merge key/value containers, where the values themselves may be containers was moved toContainerUtils.h.Some more prep-work is needed, as the XML processing code is still contained in an unnamed namespace in the
Configurationcode, which makes it impossible to use from theSpritecode.