Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why a try catch in the thumbnail.php? #35

Open
saffabook opened this issue Sep 19, 2022 · 1 comment
Open

Why a try catch in the thumbnail.php? #35

saffabook opened this issue Sep 19, 2022 · 1 comment

Comments

@saffabook
Copy link

Was wondering what the reason was for the throw in the thumbnail.php if there is an error?

Its a bit of a show stopper. If you try to make multiple images from a list of mp4s, and there is an error, eg file name incorrect, or is a dead link, the function stops. Would be good to have some set up to allow that to just return an error?

Best

@lakshmaji
Copy link
Owner

@saffabook yeah that was good idea. Bit occupied these day, would be good if we see a PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants