Skip to content
This repository has been archived by the owner on Mar 29, 2024. It is now read-only.

masking #3

Open
cubiq opened this issue Nov 14, 2023 · 1 comment
Open

masking #3

cubiq opened this issue Nov 14, 2023 · 1 comment

Comments

@cubiq
Copy link

cubiq commented Nov 14, 2023

hey @laksjdjf when working on the mask for the IPAdapter I had the same idea of doing a dedicated node 😄 Glad you had the same idea and actually did it!

did you see how I resize the mask on the IPAdapter? https://github.com/cubiq/ComfyUI_IPAdapter_plus/blob/main/IPAdapterPlus.py#L279

I'm not 100% sure it covers all the cases but I believe it's more flexible and allows any mask size. Maybe can be improved with a for/else statement.

Keep up the great work, you are a true hero 😄

PS: do you want me to write the English doc for this?

@laksjdjf
Copy link
Owner

Thanks for info!
Your implementation is smarter than now.

As for the documentation, it seems that the Japanese version needs to be updated first.
torch 2.0 is no longer required and there are many other updates.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants