Skip to content
This repository has been archived by the owner on Nov 27, 2018. It is now read-only.

s3 publish path fail #19

Closed
jtrain opened this issue Aug 1, 2012 · 2 comments
Closed

s3 publish path fail #19

jtrain opened this issue Aug 1, 2012 · 2 comments

Comments

@jtrain
Copy link

jtrain commented Aug 1, 2012

Hi I use punch on a mac. And when I do punch p I find that it tries to upload to

bucketname.aws.amazonaws.comUsers/jervis/punchwebsite/public/index.html

when it should be

bucketname.aws.amazonaws.com/index.html

I think the bug happens because deep_fstream is giving the full expanded path instead of the relative path to copyFile.

I've written some code that uses fs instead of fstream module. It works ok except there is a different bug to do with unexpected socket errors now (so I can't contribute the code as is)

@laktek laktek closed this as completed in bd43a77 Aug 2, 2012
@laktek
Copy link
Owner

laktek commented Aug 2, 2012

Thanks for spotting this issue. Fixed it in version 0.3.6.

Anyway, I'm rewriting the Punch's core these days, which will improve all these workflows. Hoping to make the release towards this weekend.

@jtrain
Copy link
Author

jtrain commented Aug 11, 2012

Thanks, I tried this out straight after you published the change. Works perfectly!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants