Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newhint#17 & Newhint#18 imports of SECP256R1_ALPHA and SECP256R1_N #1026

Merged
merged 19 commits into from
Apr 26, 2023

Conversation

mfachal
Copy link
Contributor

@mfachal mfachal commented Apr 20, 2023

TITLE

Description

Add hints #17 and #18: IMPORT_SECP256R1_ALPHA and IMPORT_SECP256R1_N

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

@mfachal mfachal marked this pull request as ready for review April 21, 2023 19:31
@github-actions
Copy link

github-actions bot commented Apr 21, 2023

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 2.886 ± 0.036 2.854 2.962 1.01 ± 0.01
head blake2s_integration_benchmark 2.853 ± 0.021 2.827 2.905 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 3.453 ± 0.063 3.406 3.614 1.02 ± 0.02
head compare_arrays_200000 3.400 ± 0.025 3.372 3.466 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 2.589 ± 0.033 2.565 2.679 1.01 ± 0.01
head dict_integration_benchmark 2.567 ± 0.015 2.544 2.590 1.00
Command Mean [s] Min [s] Max [s] Relative
base factorial_multirun 4.168 ± 0.009 4.155 4.182 1.00 ± 0.01
head factorial_multirun 4.158 ± 0.041 4.114 4.233 1.00
Command Mean [s] Min [s] Max [s] Relative
base fibonacci_1000_multirun 3.365 ± 0.021 3.346 3.399 1.01 ± 0.01
head fibonacci_1000_multirun 3.327 ± 0.027 3.301 3.400 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base field_arithmetic_get_square_benchmark 131.9 ± 1.0 130.9 133.7 1.02 ± 0.01
head field_arithmetic_get_square_benchmark 129.8 ± 0.6 128.8 131.2 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 3.311 ± 0.020 3.285 3.351 1.01 ± 0.01
head integration_builtins 3.294 ± 0.015 3.281 3.335 1.00
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 3.161 ± 0.011 3.147 3.185 1.01 ± 0.01
head keccak_integration_benchmark 3.140 ± 0.027 3.119 3.212 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 3.582 ± 0.016 3.556 3.608 1.01 ± 0.01
head linear_search 3.538 ± 0.013 3.524 3.561 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 2.974 ± 0.008 2.959 2.985 1.01 ± 0.00
head math_cmp_and_pow_integration_benchmark 2.956 ± 0.010 2.938 2.968 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 2.672 ± 0.012 2.657 2.696 1.01 ± 0.01
head math_integration_benchmark 2.656 ± 0.024 2.628 2.702 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 2.378 ± 0.058 2.343 2.539 1.00 ± 0.03
head memory_integration_benchmark 2.371 ± 0.054 2.319 2.479 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 2.388 ± 0.014 2.371 2.409 1.00 ± 0.01
head operations_with_data_structures_benchmarks 2.380 ± 0.010 2.367 2.397 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 797.6 ± 2.1 793.1 800.6 1.00 ± 0.00
head pedersen 797.0 ± 1.9 794.4 800.5 1.00
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.519 ± 0.006 1.510 1.529 1.01 ± 0.01
head poseidon_integration_benchmark 1.501 ± 0.006 1.491 1.513 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 2.665 ± 0.018 2.644 2.707 1.01 ± 0.01
head secp_integration_benchmark 2.648 ± 0.005 2.642 2.657 1.00
Command Mean [s] Min [s] Max [s] Relative
base set_integration_benchmark 1.892 ± 0.009 1.876 1.907 1.00
head set_integration_benchmark 1.897 ± 0.008 1.886 1.913 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.191 ± 0.015 4.162 4.211 1.01 ± 0.01
head uint256_integration_benchmark 4.158 ± 0.014 4.139 4.191 1.00

@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Merging #1026 (4cf1757) into main (327ee7d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1026   +/-   ##
=======================================
  Coverage   98.09%   98.09%           
=======================================
  Files          84       84           
  Lines       33837    33867   +30     
=======================================
+ Hits        33192    33222   +30     
  Misses        645      645           
Impacted Files Coverage Δ
...rocessor/builtin_hint_processor/secp/secp_utils.rs 100.00% <ø> (ø)
...int_processor/builtin_hint_processor_definition.rs 99.00% <100.00%> (+<0.01%) ⬆️
..._processor/builtin_hint_processor/secp/ec_utils.rs 99.51% <100.00%> (+0.01%) ⬆️
...processor/builtin_hint_processor/secp/signature.rs 99.02% <100.00%> (+0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pefontana pefontana added the whitelisted-hint Implementation of hint on whitelist directory label Apr 24, 2023
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@juanbono juanbono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review @fmoletta comment

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Mario Rugiero <mario.rugiero@lambdaclass.com>
@Oppen Oppen enabled auto-merge April 26, 2023 17:38
@Oppen Oppen disabled auto-merge April 26, 2023 17:39
@Oppen Oppen added this pull request to the merge queue Apr 26, 2023
Merged via the queue into main with commit 47e7b34 Apr 26, 2023
30 checks passed
@Oppen Oppen deleted the newhint17-newhint18-imports branch April 26, 2023 23:34
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jun 23, 2023
…ambdaclass#1026)

* WIP newhint#17 and newhint#18

* WIP cairo program

* add secp256r1 testing programs and newhint#17 and lambdaclass#18

* update changelog

* remove program using unimplemented hint

* add correct constants to test program

* fix broken test when executing hint lambdaclass#25 with different context

* Update CHANGELOG.md

Co-authored-by: Mario Rugiero <mario.rugiero@lambdaclass.com>

* merge

* add unit test for import alpha

---------

Co-authored-by: Mario Rugiero <mario.rugiero@lambdaclass.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
whitelisted-hint Implementation of hint on whitelist directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants