Improve run context functions #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igaray
approved these changes
May 9, 2022
azteca1998
pushed a commit
that referenced
this pull request
Feb 10, 2023
…hod (#17) * Add SyscallRequest::Deploy(DeployRequestStruct) * Start BusinessLogicSyscallHandler::_deploy implementation * Add naive implementation of fn Os::ContractAddress::calculate_contract_address_from_hash * add starknet-crypto dependecie * first implementation of fn compute_hash_on_elements + unit tests * use get_integer_range * Add bigint! and bigint_str! macros * Update fns calculate_contract_address_from_hash && compute_hash_on_elements * add SyscallHandlerError::FailToComputeHash * Minor midifications * mv src/core/os/contact_address.rs -> src/hash_utils.rs * handle Errors && cargo clippy * delete syscall_handler.rs * fix merge main conflicts * add deploy read_syscall_request * Add PartialEq to SyscallRequest * Add read_deploy_syscall_request * Modify BusinessLogicSyscallHandler::new to return self + BusinessLogicSyscallHandler::Default * Add test_calculate_contract_address_from_hash * Modify DeployStruct.deploy_from_zero to be a usize + unit test Co-authored-by: Pedro Fontana <pedro.fontana@lamdaclass.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed useless code and unnecessary error handling from the functions compute_op0_address, compute_op1_address and compute_dst_address