Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hints): Add alternative string for hint IS_ZERO_PACK_EXTERNAL_SECP #1082

Merged
merged 6 commits into from
Apr 27, 2023

Conversation

fmoletta
Copy link
Member

@fmoletta fmoletta commented Apr 27, 2023

Depends on #1081 (The hints are very similar, so I branched off of the previous one to make it easier to solve conflicts)

TITLE

Description

Description of the pull request changes and motivation.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

@fmoletta fmoletta changed the base branch from main to is-zero-pack-v2 April 27, 2023 13:51
@fmoletta fmoletta linked an issue Apr 27, 2023 that may be closed by this pull request
@fmoletta fmoletta marked this pull request as ready for review April 27, 2023 13:53
@github-actions
Copy link

github-actions bot commented Apr 27, 2023

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 3.132 ± 0.086 3.041 3.299 1.00
head blake2s_integration_benchmark 3.133 ± 0.087 2.976 3.275 1.00 ± 0.04
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 3.851 ± 0.076 3.742 3.966 1.01 ± 0.03
head compare_arrays_200000 3.810 ± 0.100 3.700 4.016 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 2.853 ± 0.067 2.702 2.932 1.00
head dict_integration_benchmark 2.863 ± 0.059 2.781 2.944 1.00 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base factorial_multirun 4.618 ± 0.082 4.490 4.752 1.00
head factorial_multirun 4.631 ± 0.055 4.547 4.738 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base fibonacci_1000_multirun 3.680 ± 0.040 3.618 3.746 1.00
head fibonacci_1000_multirun 3.706 ± 0.055 3.623 3.784 1.01 ± 0.02
Command Mean [ms] Min [ms] Max [ms] Relative
base field_arithmetic_get_square_benchmark 145.2 ± 2.2 142.2 148.6 1.00
head field_arithmetic_get_square_benchmark 146.2 ± 2.6 142.5 150.0 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 3.644 ± 0.062 3.571 3.730 1.00
head integration_builtins 3.678 ± 0.057 3.579 3.759 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 3.398 ± 0.048 3.332 3.468 1.00
head keccak_integration_benchmark 3.431 ± 0.031 3.393 3.479 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base linear_search 3.968 ± 0.029 3.925 4.033 1.02 ± 0.02
head linear_search 3.898 ± 0.064 3.829 4.023 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 3.315 ± 0.037 3.245 3.365 1.02 ± 0.02
head math_cmp_and_pow_integration_benchmark 3.242 ± 0.035 3.208 3.320 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 3.006 ± 0.088 2.899 3.226 1.01 ± 0.03
head math_integration_benchmark 2.962 ± 0.045 2.899 3.031 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 2.667 ± 0.107 2.592 2.955 1.02 ± 0.04
head memory_integration_benchmark 2.623 ± 0.042 2.559 2.671 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 2.632 ± 0.045 2.560 2.715 1.00 ± 0.04
head operations_with_data_structures_benchmarks 2.623 ± 0.085 2.471 2.696 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 890.4 ± 12.7 875.1 913.8 1.00
head pedersen 895.2 ± 12.8 880.5 917.4 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.692 ± 0.034 1.644 1.753 1.03 ± 0.05
head poseidon_integration_benchmark 1.640 ± 0.069 1.545 1.716 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 2.886 ± 0.098 2.770 3.041 1.02 ± 0.04
head secp_integration_benchmark 2.819 ± 0.074 2.730 2.955 1.00
Command Mean [s] Min [s] Max [s] Relative
base set_integration_benchmark 2.077 ± 0.074 1.960 2.188 1.02 ± 0.05
head set_integration_benchmark 2.033 ± 0.061 1.967 2.136 1.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.399 ± 0.065 4.350 4.562 1.00
head uint256_integration_benchmark 4.442 ± 0.137 4.282 4.700 1.01 ± 0.03

@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Merging #1082 (5067fb0) into main (6b4b964) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1082   +/-   ##
=======================================
  Coverage   98.10%   98.10%           
=======================================
  Files          84       84           
  Lines       34161    34164    +3     
=======================================
+ Hits        33515    33518    +3     
  Misses        646      646           
Impacted Files Coverage Δ
...int_processor/builtin_hint_processor_definition.rs 99.02% <100.00%> (+<0.01%) ⬆️
...ocessor/builtin_hint_processor/secp/field_utils.rs 99.70% <100.00%> (+<0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Base automatically changed from is-zero-pack-v2 to main April 27, 2023 19:09
@fmoletta fmoletta added this pull request to the merge queue Apr 27, 2023
Merged via the queue into main with commit 3f093ba Apr 27, 2023
@fmoletta fmoletta deleted the is-zero-pack-external-v2 branch April 27, 2023 22:11
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jun 23, 2023
…CP (lambdaclass#1082)

* Add alternative hint code IS_ZERO_PACK_V2

* Integrate into existing tests

* Add changelog entry

* Add alternative string for hint IS_ZERO_PACK_EXTERNAL_SECP

* Add changelog entry + fix unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NewHint#22 shouldn't appear in issue #1031
3 participants