-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: wrap big variants of errors in Box
#1193
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark Results for unmodified programs 🚀
|
HintError
's variants' contents in Box
HintError
in Box
HintError
in Box
HintError
in Box
fmoletta
approved these changes
May 31, 2023
Codecov Report
@@ Coverage Diff @@
## main #1193 +/- ##
==========================================
- Coverage 97.69% 97.62% -0.08%
==========================================
Files 89 89
Lines 35975 36038 +63
==========================================
+ Hits 35147 35182 +35
- Misses 828 856 +28
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Oppen
approved these changes
May 31, 2023
HintError
in Box
Box
Oppen
reviewed
Jun 1, 2023
Some benches seem much slower. Make sure the allocations only happen on error paths. |
Oppen
reviewed
Jun 1, 2023
Oppen
reviewed
Jun 1, 2023
kariy
pushed a commit
to dojoengine/cairo-rs
that referenced
this pull request
Jun 23, 2023
* Wrap HintError's variants' contents in Box * Fix half of the errors * Fix compile warnings * Use `crate::stdlib`'s `Box` * Appease clippy * Add simple smoke tests of message formatting * Update changelog * Mention change is breaking * Box `MathError` variants * Box `MemoryError` variants * Box HintError variants (now also strings) * Add tentative test to avoid size regressions * Box `VirtualMachineError` * Box RunnerError * Appease clippy * Use `crate::stdlib`'s `Box` * Update changelog with recent changes * fix: replace several ok_ok by ok_or_else for perf regression * Replace more ok_or for ok_or_else * Add missing regression test * Use `Box<str>` instead of `Box<String>` --------- Co-authored-by: Mario Rugiero <mrugiero@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TITLE
Description
Some
HintError
variants can be pretty big (e.g.ArcTooBig
). This PRBox
es their contents. That way we can still match those variants, but they occupy less space. This also helps #1184, as with the change from heap to stack-living types the felts and relocatables grow even bigger.Checklist