-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Felt252 use lambdaworks field element #1184
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also comment `from` impls for primitive numbers and (De)Serialize derives
MegaRedHand
requested review from
igaray,
fmoletta,
entropidelic,
juanbono and
Juan-M-V
as code owners
June 8, 2023 14:09
Using `get_ref` and later updating the variable with an `exec_scopes.insert_value(...)` causes two lookups in a hashmap, along with two creation of `String` from a slice. This change reduces it to just a single lookup and `String` creation.
Oppen
reviewed
Jun 15, 2023
Oppen
reviewed
Jun 22, 2023
@@ -2,6 +2,9 @@ | |||
|
|||
#### Upcoming Changes | |||
|
|||
* feat: `Felt252` now uses _lambdaworks_' `FieldElement` internally |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it implements Copy
now, add it to the changelog.
Merged in d0804dd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TITLE
Description
Closes: #1197
This PR changes current
Felt252
backend from num_bigint'sFeltBigInt
to lambdawork'sFieldElement<Stark252PrimeField>
.Step by Step to benchmark lambdawork FieldElement:
Create binaries
Create binary from main
// Main las commit
Create binary from lambdaworks-felt
// lambdaworks-felt last commit (cambiarlo con el ultimo commit)
Compile cairo program
Install dependencies if neesary
Linux users
Mac users
Run benchmarks