Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement substitute_error_message_attribute_references #689

Merged
merged 25 commits into from
Jan 12, 2023
Merged

Implement substitute_error_message_attribute_references #689

merged 25 commits into from
Jan 12, 2023

Conversation

fmoletta
Copy link
Member

@fmoletta fmoletta commented Jan 5, 2023 •
edited
Loading

The aim of this pr is to replace the references in the error attribute messages with their cairo value

  • Add function substitute_error_message_attribute_references
  • Remove leftover error attribute message handling leading to duplicated messages
  • Add unit + integration tests for new functionality

@fmoletta
Add flow_tracking_data to Attribute
0f62bba
@fmoletta
Start substitute_error_message_references method
81b7294
@fmoletta
First draft
e0dc119
@fmoletta
Finish first draft
7d05b3b
@fmoletta
Remove duplicated error_attr management
538acf9
@fmoletta
Fix string format
923421a
@fmoletta
Fix invalid reference string + filter out ap-based references
23c9fcb
@fmoletta
Copy get_maybe_relocatable_from_reference from PR 687
9f98269
@fmoletta
Filter out complex cairo types
10e1ef4
@fmoletta
Clippy
195ab4f
@fmoletta
Add tests for ap-based references in error attribute messages
bd8a1e0
@fmoletta
Add tests for complex references in error attribute messages
5470d1b
@fmoletta
Start changelog entry
093a87b
@fmoletta
Merge branch 'main' of github.com:lambdaclass/cairo-rs into substitut…
997d050 
…e-error-attr-ref
@fmoletta
Merge branch 'main' of github.com:lambdaclass/cairo-rs into substitut…
0b89b93 
…e-error-attr-ref
@fmoletta
Fix eof
56e5298
@fmoletta
Add changelog entry
a819eeb
@fmoletta
Fix test
4d44dd0
@fmoletta
Update changelog
ef50803
@fmoletta fmoletta marked this pull request as ready for review January 6, 2023 14:24
@fmoletta fmoletta mentioned this pull request Jan 6, 2023
Merged
Jrigada
Jrigada approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@Jrigada Jrigada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jrigada Jrigada merged commit 8c17f63 into main Jan 12, 2023
@Jrigada Jrigada deleted the substitute-error-attr-ref branch January 12, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jrigada Jrigada Jrigada approved these changes

@Juan-M-V Juan-M-V Juan-M-V approved these changes

@igaray igaray Awaiting requested review from igaray igaray is a code owner

@Oppen Oppen Awaiting requested review from Oppen Oppen is a code owner

@entropidelic entropidelic Awaiting requested review from entropidelic

@HermanObst HermanObst Awaiting requested review from HermanObst

@juanbono juanbono Awaiting requested review from juanbono juanbono is a code owner

@pefontana pefontana Awaiting requested review from pefontana pefontana is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fmoletta @Jrigada @Juan-M-V