Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement substitute_error_message_attribute_references #689

Merged
merged 25 commits into from
Jan 12, 2023

Conversation

fmoletta
Copy link
Member

@fmoletta fmoletta commented Jan 5, 2023

The aim of this pr is to replace the references in the error attribute messages with their cairo value

  • Add function substitute_error_message_attribute_references
  • Remove leftover error attribute message handling leading to duplicated messages
  • Add unit + integration tests for new functionality

Copy link
Contributor

@Jrigada Jrigada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jrigada Jrigada merged commit 8c17f63 into main Jan 12, 2023
@Jrigada Jrigada deleted the substitute-error-attr-ref branch January 12, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants