-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify Memory::get return
type to Option
#852
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #852 +/- ##
==========================================
- Coverage 96.82% 96.82% -0.01%
==========================================
Files 69 69
Lines 28835 28804 -31
==========================================
- Hits 27920 27889 -31
Misses 915 915
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Oppen
approved these changes
Feb 17, 2023
…able values (#853) * Print relocatables & missing members in write_output * Add test
juanbono
approved these changes
Feb 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Memory::get & Memory::get_maybe to return an Option instead of Result<Option
Change
MaybeReloctable::get_int_ref
&MaybeReloctable::get_relocatable
to return Option instead of Result (previous error had incorrect info)Fix errors used by the range_check builtin (add info & change name) + remove use of these errors outside of range_check methods
Add error
UnknownMemoryCell
Refactor a hint to use
get_integer_range
instead of using get_range and the checking for None or non-integer valuesl