Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move memory-related errors to MemoryError #854

Merged
merged 19 commits into from
Feb 24, 2023
Merged

Conversation

fmoletta
Copy link
Member

@fmoletta fmoletta commented Feb 17, 2023

@fmoletta fmoletta changed the base branch from main to memory-get-option February 17, 2023 20:38
@fmoletta fmoletta marked this pull request as ready for review February 17, 2023 21:22
@fmoletta fmoletta changed the title Move memory-related errors to MemoryError Move memory-related errors to MemoryError Feb 17, 2023
Copy link
Member

@juanbono juanbono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Merging #854 (c718073) into main (763fc5f) will increase coverage by 0.01%.
The diff coverage is 97.93%.

@@            Coverage Diff             @@
##             main     #854      +/-   ##
==========================================
+ Coverage   96.82%   96.84%   +0.01%     
==========================================
  Files          69       69              
  Lines       28804    28784      -20     
==========================================
- Hits        27889    27875      -14     
+ Misses        915      909       -6     
Impacted Files Coverage Δ
...t_processor/builtin_hint_processor/dict_manager.rs 96.73% <ø> (+1.00%) ⬆️
src/hint_processor/hint_processor_utils.rs 88.84% <0.00%> (+0.37%) ⬆️
src/vm/trace/mod.rs 92.50% <0.00%> (ø)
..._processor/builtin_hint_processor/blake2s_utils.rs 99.49% <100.00%> (+<0.01%) ⬆️
...int_processor/builtin_hint_processor_definition.rs 98.67% <100.00%> (ø)
...uiltin_hint_processor/cairo_keccak/keccak_hints.rs 93.93% <100.00%> (+0.40%) ⬆️
...rocessor/builtin_hint_processor/dict_hint_utils.rs 99.22% <100.00%> (ø)
...int_processor/builtin_hint_processor/hint_utils.rs 94.59% <100.00%> (ø)
...int_processor/builtin_hint_processor/math_utils.rs 97.94% <100.00%> (-0.01%) ⬇️
...t_processor/builtin_hint_processor/memset_utils.rs 100.00% <100.00%> (ø)
... and 21 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Base automatically changed from memory-get-option to main February 23, 2023 13:14
Copy link
Contributor

@Jrigada Jrigada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change!

@Jrigada Jrigada added this pull request to the merge queue Feb 24, 2023
Merged via the queue into main with commit e0da0be Feb 24, 2023
@Jrigada Jrigada deleted the remove-memory-get-error branch February 24, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants