Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement hints on common/ec.cairo #888

Merged
merged 35 commits into from
Mar 17, 2023
Merged

Implement hints on common/ec.cairo #888

merged 35 commits into from
Mar 17, 2023

Conversation

fmoletta
Copy link
Member

@fmoletta fmoletta commented Mar 9, 2023

Implements 3 new hints in common/ec_op.rs
Code for sqrt was taken from open PR #715
This branch stems from pre-wasm/no-std-revert

@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #888 (815b9a2) into main (82089bf) will increase coverage by 0.01%.
The diff coverage is 98.31%.

@@            Coverage Diff             @@
##             main     #888      +/-   ##
==========================================
+ Coverage   97.39%   97.41%   +0.01%     
==========================================
  Files          69       70       +1     
  Lines       29279    29697     +418     
==========================================
+ Hits        28516    28929     +413     
- Misses        763      768       +5     
Impacted Files Coverage Δ
felt/src/lib.rs 89.59% <92.85%> (+0.15%) ⬆️
src/math_utils.rs 99.43% <98.33%> (-0.15%) ⬇️
.../hint_processor/builtin_hint_processor/ec_utils.rs 99.01% <99.01%> (ø)
felt/src/bigint_felt.rs 96.07% <100.00%> (+0.02%) ⬆️
...int_processor/builtin_hint_processor_definition.rs 98.69% <100.00%> (+<0.01%) ⬆️

... and 14 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@Jrigada Jrigada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the layout "all" would need a change of name in the future

@juanbono juanbono added this pull request to the merge queue Mar 17, 2023
@juanbono juanbono merged commit 74ea6b9 into main Mar 17, 2023
@juanbono juanbono deleted the add-ec-hints branch March 17, 2023 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants