Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Get composition and trace polynomials from AIR using modified winterfell and giza #128

Closed
wants to merge 29 commits into from
Closed

feat: Get composition and trace polynomials from AIR using modified winterfell and giza #128

wants to merge 29 commits into from

Conversation

entropidelic
Copy link
Contributor

@entropidelic entropidelic commented Feb 28, 2023 •
edited
Loading

ref #43

This PR implements functionality to get a composition and trace polynomials from a trace and an AIR, using a modified versions of winterfell and giza.

  • Implemented the function get_cp_and_tp, that takes as input a trace and an AIR as defined by winterfell and giza data structures, and outputs composition and trace polynomials as our Polynomial data structure. This function is designed to work for any trace and AIR as long as they are defined using the Felt data type from giza. This includes the Cairo AIR, defined in giza as ProcessorAir struct.
  • Implemented tests for proving and verifying fibonacci computation and for getting composition and trace polynomials from fibonacci and Cairo computations.

Note: Due to some incorrect assertions done in winterfell in debug mode, these tests should be run in release mode.

@entropidelic entropidelic marked this pull request as ready for review February 28, 2023 16:12
@entropidelic entropidelic requested review from a team, schouhy and ajgara as code owners February 28, 2023 16:12
pablodeymo and others added 26 commits February 28, 2023 13:27
@pablodeymo @entropidelic
prover sub crate created
ad4dbde
@entropidelic
Save work in progress
a667e19
@entropidelic
Add first iteration of function to get composition polynomials from t…
d90723c 
…race and air
@entropidelic
Add test for get_composition_poly
c1ebac0
@entropidelic
Add get_coefficients function
3cbeb36
@entropidelic
Tidy up code
879bad5
@entropidelic
Add docs
1774449
@entropidelic
Fix tests
a28fe8e
@entropidelic
Add u128_prime field and make get_composition_poly return a Polynomia…
56b8431 
…l data structure
@entropidelic
Fixes from rebasing
79579b7
@entropidelic
Apply clippy suggestions
ee3c57e
@entropidelic
Make functions pub crate
4db9ae9
@entropidelic
Tidy up code
8c9530f
@entropidelic
Tidy up code
37d1c7f
@entropidelic
Minor fixes
506f156
@entropidelic
Start integrating with Giza
128277a
@entropidelic
Fix get_composition_poly to work with giza AIR
94256c1
@entropidelic
Branch from arithmetization with Giza AIR
5ccfb86
@entropidelic
Generate trace from file
2d4aeee
@entropidelic
Integrate arithmetization with giza AIR
2b72dc7
@entropidelic
Tidy up code
1d8b449
@entropidelic
Refactor to output trace polynomials
b4e06a9
@entropidelic
Use fibonacci air in test
41ecec6
@entropidelic
Add fibonacci computation verification test
4c49ca0
@entropidelic
Update test program files
7817e6a
@entropidelic
Add some clippy suggestions
41529e0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schouhy schouhy Awaiting requested review from schouhy

@ajgara ajgara Awaiting requested review from ajgara

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@entropidelic @pablodeymo