Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added PluginAwareInterface and marked EventsCapableInterface as deprecated #2

Closed
weierophinney opened this issue Dec 31, 2019 · 6 comments

Comments

@weierophinney
Copy link
Member

Since the StorageFactory only checks for the EventsCapableInterface, it would result in a Call to undefined method WhateverStorage::hasPlugin.

Therefore, I would like to introduce that PluginAwareInterface for ZF3 and until then, I would like to mark the EventsCapableInterface usage as deprecated and provide this backport request.


Originally posted by @boesing at zendframework/zend-cache#177

@weierophinney
Copy link
Member Author

@boesing
The target version is 2.9?


Originally posted by @froschdesign at zendframework/zend-cache#177 (comment)

@weierophinney
Copy link
Member Author

@froschdesign I'm not sure since I did not got into those release processes already. If thats a change for 2.8, I could change the target branch to master


Originally posted by @boesing at zendframework/zend-cache#177 (comment)

@weierophinney
Copy link
Member Author

No no, the develop branch is correct!

I looked at the code and thought that it is for version 3 and then I saw the deprecation info. A deprecation goes in the next minor release.


Originally posted by @froschdesign at zendframework/zend-cache#177 (comment)

@weierophinney
Copy link
Member Author

I guess this PR is ready to merge now @froschdesign, would be great if you drop the WIP label. Thanks.


Originally posted by @boesing at zendframework/zend-cache#177 (comment)

@weierophinney
Copy link
Member Author

I really could need this PR in my latest project boesing/zend-cache-redis-cluster as I want to work with that PluginCapableInterface::getPluginRegistry to determine search for the serializer plugin.

I guess anything is on hold until we have more news about laminas?


Originally posted by @boesing at zendframework/zend-cache#177 (comment)

@boesing
Copy link
Member

boesing commented Nov 8, 2020

Closed with #21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants