Add mysqli connection flags to mysqli_real_connect

[michalbundyra]

The Mysqli driver doesn't allow setting of flags passed into mysqli_real_connect.

• Are you fixing a bug?
  • Detail how the bug is invoked currently.

In some instances (like MySQL and PHP on Azure) MYSQLI_SSL_CLIENT needs to be set.

'params' => [
    'host' => 'xxxx.mysql.database.azure.com',
    'port' => 3306,
    'user' => 'xxxx@xxxxx',
    'password' => 'xxxxx',
    'dbname' => 'xxxx',
    'charset' => 'utf8',
    'use_ssl' => true,
    'ssl_ca' => 'xxxxx/certs/BaltimoreCyberTrustRoot.crt.pem',
    'driver_options' => [ ]
]

• Detail the original, incorrect behavior.

This calls $this->resource->ssl_set($clientKey, $clientCert, $caCert, $caPath, $cipher); to configure the SSL options, but no flag is set on mysqli_real_connect. Connection to Azure subsequently fails with 'SSL connection is required'

• Detail the new, expected behavior.

Driver should allow connecting as illustrated in azure documentation at https://docs.microsoft.com/en-us/azure/mysql/howto-configure-ssl .

Added 'flags' config key to driver_options to support the setting of flags into mysqli_real_connect. This lets users supply MYSQLI_CLIENT_SSL and other connection flags as indicated on http://www.php.net/manual/en/mysqli.real-connect.php

'params' => [
    'host' => 'xxxx.mysql.database.azure.com',
    'port' => 3306,
    'user' => 'xxxx@xxxxx',
    'password' => 'xxxxx',
    'dbname' => 'xxxx',
    'charset' => 'utf8',
    'use_ssl' => true,
    'ssl_ca' => 'xxxxx/certs/BaltimoreCyberTrustRoot.crt.pem',
    'driver_options' => [ 
        'flags' => MYSQLI_CLIENT_SSL 
    ]
]

---

Originally posted by @kris-sum at zendframework/zend-db#314

[michalbundyra]

Is anyone available to review this? @ezimuel @weierophinney ?

---

Originally posted by @kris-sum at zendframework/zend-db#314 (comment)

[michalbundyra]

@kris-sum We need test case for this change.

---

Originally posted by @michalbundyra at zendframework/zend-db#314 (comment)

[michalbundyra]

@webimpress Any test case would require setting up SSL on the MySQL end - I can't see a way I can do that with the current integration test setup?

---

Originally posted by @kris-sum at zendframework/zend-db#314 (comment)

[michalbundyra]

@kris-sum mock resource, pass it into the constructor and check if calls are with proper values/flags. Seems to be doable.

---

Originally posted by @michalbundyra at zendframework/zend-db#314 (comment)

[michalbundyra]

@kris-sum can you provide the unit test as suggested by @webimpress ? Thanks.

---

Originally posted by @ezimuel at zendframework/zend-db#314 (comment)

[demiankatz]

@webimpress, @michalbundyra, as @kris-sum pointed out above, PR #169 should resolve this issue. What needs to be done to get that PR merged? Happy to help in any way I can, as this fix would be very helpful to have!

[weierophinney]

This package is considered feature-complete, and is now in security-only maintenance mode, following a decision by the Technical Steering Committee.
If you have a security issue, please follow our security reporting guidelines.
If you wish to take on the role of maintainer, please nominate yourself

If you are looking for an actively maintained package alternative, we recommend:

• doctrine/dbal