Normalize line-folded headers values to not contain newlines #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
approved these changes
May 4, 2022
As per RFC 7230#3.2.4: > A server that receives an obs-fold in a request message that is not > within a message/http container MUST […] replace > each received obs-fold with one or more SP octets prior to > interpreting the field value or forwarding the message downstream. > […] > A user agent that receives an obs-fold in a response message that is > not within a message/http container MUST replace each received > obs-fold with one or more SP octets prior to interpreting the field > value. Furthermore this change improves interoperability with PSR-7 implementations that reject line folding. The updated behavior matches the suggested behavior with regard to the handling of line-folding in the new php-fig/fig-standards#1274 erratum. Signed-off-by: Tim Düsterhus <duesterhus@woltlab.com>
TimWolla
force-pushed
the
normalize-line-folding
branch
from
296cc0e
to
da685b9
Compare
|
Rebased to add the missing |
|
IMO OK for |
I'm fine either way. This is a fix for an obscure corner case of the HTTP spec and not something users will encounter in the real world. |
weierophinney
approved these changes
May 4, 2022
My pleasure. Thanks from my side for Diactoros and also for the super nice and speedy handling of my PRs 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per RFC 7230#3.2.4:
Furthermore this change improves interoperability with PSR-7 implementations
that reject line folding.
The updated behavior matches the suggested behavior with regard to the handling
of line-folding in the new php-fig/fig-standards#1274 erratum.