Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃毟 Do not allow creating files with none of key, description and run #1022

Merged
merged 14 commits into from Aug 11, 2023

Conversation

falexwolf
Copy link
Member

@falexwolf falexwolf commented Aug 11, 2023

This PR got pretty heavily cluttered up due to a failed rebase... but the change should be evident from the title.

It required refactoring quite a few tests.

@falexwolf falexwolf changed the title 馃毟 Do not allow creating files with none of key, description and run set 馃毟 Do not allow creating files with none of key, description and run Aug 11, 2023
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #1022 (b58a692) into staging (0a37ec8) will increase coverage by 0.03%.
The diff coverage is 90.00%.

@@             Coverage Diff             @@
##           staging    #1022      +/-   ##
===========================================
+ Coverage    86.55%   86.59%   +0.03%     
===========================================
  Files           43       43              
  Lines         3318     3319       +1     
===========================================
+ Hits          2872     2874       +2     
+ Misses         446      445       -1     
Files Changed Coverage 螖
lamindb/_dataset.py 82.41% <66.66%> (+0.19%) 猬嗭笍
lamindb/_file.py 90.36% <100.00%> (+0.14%) 猬嗭笍
lamindb/_parents.py 95.51% <100.00%> (+0.05%) 猬嗭笍

馃摚 We鈥檙e building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

@github-actions github-actions bot temporarily deployed to pull request August 11, 2023 16:19 Inactive
@falexwolf falexwolf merged commit 498c9cc into staging Aug 11, 2023
11 checks passed
@falexwolf falexwolf deleted the strict branch August 11, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants