New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃毟 Do not allow creating files with none of key, description and run #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
falexwolf
changed the title
馃毟 Do not allow creating files with none of key, description and run set
馃毟 Do not allow creating files with none of key, description and run
Aug 11, 2023
Co-authored-by: Alex Wolf <f.alexander.wolf@gmail.com> Co-authored-by: github-actions <github-actions@github.com>
Signed-off-by: zethson <lukas.heumos@posteo.net>
Codecov Report
@@ Coverage Diff @@
## staging #1022 +/- ##
===========================================
+ Coverage 86.55% 86.59% +0.03%
===========================================
Files 43 43
Lines 3318 3319 +1
===========================================
+ Hits 2872 2874 +2
+ Misses 446 445 -1
馃摚 We鈥檙e building smart automated test selection to slash your CI/CD build times. Learn more |
馃殌 Deployed on https://64d65f8d0aeedc7fa8e94539--lamindb-qnwk.netlify.app |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR got pretty heavily cluttered up due to a failed rebase... but the change should be evident from the title.
It required refactoring quite a few tests.