Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Track storage root location #137

Merged
merged 6 commits into from
Aug 22, 2022
Merged

Conversation

fredericenard
Copy link
Collaborator

@fredericenard fredericenard commented Aug 19, 2022

@github-actions
Copy link

@github-actions github-actions bot temporarily deployed to pull request August 19, 2022 19:33 Inactive
@codecov
Copy link

codecov bot commented Aug 19, 2022

Codecov Report

Merging #137 (f3006c8) into main (ed3ba9c) will increase coverage by 0.63%.
The diff coverage is 94.64%.

❗ Current head f3006c8 differs from pull request most recent head 24f4a1e. Consider uploading reports for the commit 24f4a1e to get more accurate results

@@            Coverage Diff             @@
##             main     #137      +/-   ##
==========================================
+ Coverage   90.30%   90.93%   +0.63%     
==========================================
  Files          31       31              
  Lines         598      640      +42     
==========================================
+ Hits          540      582      +42     
  Misses         58       58              
Impacted Files Coverage Δ
lamindb/_check_versions.py 69.23% <57.14%> (ø)
lamindb/datasets.py 100.00% <100.00%> (ø)
lamindb/dev/__init__.py 100.00% <100.00%> (ø)
lamindb/dev/_core.py 100.00% <100.00%> (ø)
lamindb/dev/db/_insert.py 93.00% <100.00%> (+0.81%) ⬆️
lamindb/do/_ingest.py 94.11% <100.00%> (+0.93%) ⬆️
lamindb/do/_query.py 86.17% <100.00%> (+0.70%) ⬆️
lamindb/schema/__init__.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fredericenard
Copy link
Collaborator Author

image

I don't understand why this happens, it's like the new version of lnschema_core was not used during setup. Locally everything works.

@fredericenard fredericenard changed the title Track cloud workspace location Track storage root location of a dobject Aug 21, 2022
@falexwolf falexwolf changed the title Track storage root location of a dobject ✨ Track storage root location Aug 21, 2022
@falexwolf
Copy link
Member

I think this error comes from the s3 bucket lamin0 already containing an existing lamindb instance that has not yet been migrated to the current schema. It likely prints out a warning somewhere, but it doesn't error (to allow the user to debug and manually migrate).
image

I'll remove the instance (sqlite file within bucket lamin0) and then run this again.

@falexwolf
Copy link
Member

This worked! Now I just need to the current core schema version to the hub:
image

@falexwolf
Copy link
Member

Worked!

Now one needs to update lndb-hub to the new schema:
image

@falexwolf
Copy link
Member

I'll merge this for now so that we unblock downstream PRs.

We'll fix CI after.

@falexwolf falexwolf merged commit e8c909a into main Aug 22, 2022
@falexwolf falexwolf deleted the track-cloud-workspace-location branch August 22, 2022 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants