Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Use future annotations #1549

Merged
merged 7 commits into from Apr 4, 2024
Merged

✨ Use future annotations #1549

merged 7 commits into from Apr 4, 2024

Conversation

Zethson
Copy link
Member

@Zethson Zethson commented Apr 4, 2024

Signed-off-by: zethson <lukas.heumos@posteo.net>
Signed-off-by: zethson <lukas.heumos@posteo.net>
Signed-off-by: zethson <lukas.heumos@posteo.net>
Signed-off-by: zethson <lukas.heumos@posteo.net>
@falexwolf
Copy link
Member

Oh, this is pretty! 🤩

Signed-off-by: zethson <lukas.heumos@posteo.net>
Signed-off-by: zethson <lukas.heumos@posteo.net>
Signed-off-by: zethson <lukas.heumos@posteo.net>
@Zethson Zethson marked this pull request as ready for review April 4, 2024 13:19
Copy link

github-actions bot commented Apr 4, 2024

@github-actions github-actions bot temporarily deployed to pull request April 4, 2024 13:21 Inactive
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 87.54864% with 32 lines in your changes are missing coverage. Please review.

Project coverage is 92.18%. Comparing base (2200325) to head (d825708).
Report is 1 commits behind head on main.

Files Patch % Lines
lamindb/_can_validate.py 66.66% 3 Missing ⚠️
lamindb/_finish.py 50.00% 3 Missing ⚠️
lamindb/_collection.py 88.88% 2 Missing ⚠️
lamindb/core/_feature_manager.py 81.81% 2 Missing ⚠️
lamindb/core/_settings.py 87.50% 2 Missing ⚠️
lamindb/core/storage/_backed_access.py 81.81% 2 Missing ⚠️
lamindb/_annotate.py 92.30% 1 Missing ⚠️
lamindb/_artifact.py 93.33% 1 Missing ⚠️
lamindb/_feature.py 87.50% 1 Missing ⚠️
lamindb/_from_values.py 85.71% 1 Missing ⚠️
... and 14 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1549      +/-   ##
==========================================
- Coverage   92.74%   92.18%   -0.56%     
==========================================
  Files          49       49              
  Lines        5015     5067      +52     
==========================================
+ Hits         4651     4671      +20     
- Misses        364      396      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Zethson Zethson merged commit 6068929 into main Apr 4, 2024
11 of 13 checks passed
@Zethson Zethson deleted the feature/future_annotations branch April 4, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to future annotations
2 participants