Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Refactor linked select #286

Merged
merged 13 commits into from
Oct 18, 2022
Merged

♻️ Refactor linked select #286

merged 13 commits into from
Oct 18, 2022

Conversation

sunnyosun
Copy link
Member

@sunnyosun sunnyosun commented Oct 13, 2022

Refactored linked select for dobjects.

@github-actions
Copy link

github-actions bot commented Oct 18, 2022

@github-actions github-actions bot temporarily deployed to pull request October 18, 2022 13:31 Inactive
@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Merging #286 (338ee8c) into main (9fc7a20) will increase coverage by 1.10%.
The diff coverage is 94.25%.

❗ Current head 338ee8c differs from pull request most recent head 0fbbcb6. Consider uploading reports for the commit 0fbbcb6 to get more accurate results

@@            Coverage Diff             @@
##             main     #286      +/-   ##
==========================================
+ Coverage   87.66%   88.77%   +1.10%     
==========================================
  Files          35       35              
  Lines        1143     1158      +15     
==========================================
+ Hits         1002     1028      +26     
+ Misses        141      130      -11     
Impacted Files Coverage Δ
lamindb/dev/db/_staged.py 84.48% <ø> (ø)
lamindb/dev/db/_core.py 95.12% <94.11%> (+4.79%) ⬆️
lamindb/dev/db/_select.py 95.67% <94.28%> (+6.50%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions github-actions bot temporarily deployed to pull request October 18, 2022 13:57 Inactive
@sunnyosun sunnyosun merged commit ff66517 into main Oct 18, 2022
@sunnyosun sunnyosun deleted the refactor_select branch October 18, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant