Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚸 Remove execution of cells after metadata write #159

Merged
merged 1 commit into from
Jul 14, 2022
Merged

Conversation

falexwolf
Copy link
Member

@falexwolf falexwolf commented Jul 14, 2022

@Zethson experienced that notebooks cells were actually executed after publish().

This should evidently not be the case. The original rationale for the former line of code was to display the header automatically after init. But that doesn't work for me anyway, and it's also not a big deal if one needs to manually run the first cell after init.

@github-actions
Copy link

@github-actions github-actions bot temporarily deployed to pull request July 14, 2022 15:12 Inactive
@falexwolf falexwolf changed the title 🚸 Remove execution of cells 🚸 Remove execution of cells after metadata write Jul 14, 2022
@falexwolf falexwolf changed the title 🚸 Remove execution of cells after metadata write 🚸 Remove execution of cells after metadata write Jul 14, 2022
@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #159 (5902690) into main (fcc7399) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #159   +/-   ##
=======================================
  Coverage   79.62%   79.62%           
=======================================
  Files          17       17           
  Lines         805      805           
=======================================
  Hits          641      641           
  Misses        164      164           
Impacted Files Coverage Δ
nbproject/dev/_jupyter_lab_commands.py 33.33% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcc7399...5902690. Read the comment docs.

@falexwolf falexwolf merged commit 0d10ee0 into main Jul 14, 2022
@falexwolf falexwolf deleted the integrity branch July 14, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant