Avoid embedding SelectionProtos in Conversions #17755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the minimisation of the specs2 failure that occurred in CI, the conversion desired is `Conversion[String, Bar.this.Data]`. But if we use the given's symbol info, we end up with the type `Conversion[String, Foo.this.Data]` which the generated tree will fail to adapt to. Using the widening of the implicit candidate's TermRef will yield a method type, as seen from the right prefix - `Bar.this.Data`.
odersky
reviewed
Jun 4, 2023
| // see tests/pos/i15867.scala. | ||
| restpe | ||
| case _ => pt | ||
| case _ => pt |
| // so instead replace it with the targeted conversion type, if it matches | ||
| // see tests/pos/i15867.scala. | ||
| restpe | ||
| case _ => pt |
There was a problem hiding this comment.
But in this case and also on the next line we still get a SelectionProto in the result type of the conversion, which looks fishy. Can we replace with NoType instead?
odersky
added a commit
that referenced
this pull request
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.