-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pre-built custom sql.js for sqliteviz #62
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are a few bug reports about first build run failing and second succeeding for |
lana-k
approved these changes
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To be able provide sqliteviz builds with fresh SQLite, and incorporate valuable SQLite "own" and 3rd party extensions, this PR proposes Docker-based scripts to build WASM sql.js.
To avoid requiring build dependencies for every potential contributor, commit built
sql-wasm.js
andsql-wasm.wasm
in the repo.Extensions
Included/enabled extensions are documented in
lib/sql-js/README.md
.To do
npm run build
fails first time (2nd attempt works) with cryptic:lib/sql-js/README.md
.Reference
Statically built auto-registered SQLite extensions: