Skip to content

Commit

Permalink
#1375: Fixed busted drush global-local site handoff
Browse files Browse the repository at this point in the history
  • Loading branch information
pirog committed Feb 2, 2019
1 parent 2450583 commit fc64beb
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 3 deletions.
1 change: 1 addition & 0 deletions docs/changelog/2019.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ v3.0.0-rc.3 - [Febraury 3, 2019](https://github.com/lando/lando/releases/tag/v3.

* Fixed `postgres` config loading preventing outside connections [#1379](https://github.com/lando/lando/issues/1379)
* Fixed busted auto-naming on Windows deploy [#1375](https://github.com/lando/lando/issues/1375)
* Fixed busted `drush` global-local handoff on Pantheon [#1375](https://github.com/lando/lando/issues/1375)

v3.0.0-rc.2 - [Febraury 1, 2019](https://github.com/lando/lando/releases/tag/v3.0.0-rc.2)
--------------------------------
Expand Down
5 changes: 5 additions & 0 deletions examples/drupal8/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,11 @@ lando composer require drupal/console:~1.0 --prefer-dist --optimize-autoloader
# Should have drupal console
cd drupal8
lando drupal -V

# Should be able to handoff to sitelocal drush without issue
cd drupal8
lando composer require drush/drush
lando rebuild -y
```

Destroy tests
Expand Down
2 changes: 1 addition & 1 deletion plugins/lando-pantheon/lib/utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ const getPantheonSettings = options => ({
exports.getPantheonBuildSteps = framework => {
if (framework === 'wordpress') return [getPhar(wpCliUrl, '/tmp/wp-cli.phar', '/usr/local/bin/wp', wpStatusCheck)];
else {
const build = [getDrush(DRUSH_VERSION, ['/tmp/drush.phar', 'core-status'])];
const build = [getDrush(DRUSH_VERSION, ['drush', 'status'])];
if (framework === 'drupal8') {
build.push(getPhar(
'https://drupalconsole.com/installer',
Expand Down
2 changes: 1 addition & 1 deletion plugins/lando-recipes/recipes/backdrop/builder.js
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ module.exports = {
via: 'cli',
overrides: {image: 'devwithlando/php:5.5-fpm'},
build_internal: [
utils.getDrush(options.drush, ['/tmp/drush.phar', 'core-status']),
utils.getDrush(options.drush, ['drush', 'status']),
backdrushInstall(options.backdrush),
],
});
Expand Down
2 changes: 1 addition & 1 deletion plugins/lando-recipes/types/drupaly/builder.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ module.exports = {
if (!_.has(options, 'drush')) options.drush = (options.php === '5.3') ? DRUSH7 : DRUSH8;
// Add the drush install command
if (!_.isNull(semver.valid(options.drush)) && semver.major(options.drush) === 8) {
options.build.unshift(utils.getDrush(options.drush, ['/tmp/drush.phar', 'core-status']));
options.build.unshift(utils.getDrush(options.drush, ['drush', 'status']));
} else if (options.drush !== false) {
options.composer['drush/drush'] = options.drush;
}
Expand Down

0 comments on commit fc64beb

Please sign in to comment.