Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the node application container/language for the p.sh recipe #66

Open
pirog opened this issue Jun 8, 2020 · 4 comments
Open

Comments

@pirog
Copy link
Member

pirog commented Jun 8, 2020

This should be fairly straightforward to add however we may have a problem because the command you run to serve the app in production may not be the same command you want to run to develop the app locally.

TBD on how to resolve that problem.

lets wait until we've got php mostly sorted out before we move on this

@ralt
Copy link

ralt commented Jun 30, 2020

One potential solution is having a start command being e.g.: if [ $SOMETHING = lando ]; then ... else ... endif

@pirog
Copy link
Member Author

pirog commented Jun 30, 2020

@ralt good call, we set $LANDO so that would be the obvious one to use.

@pirog
Copy link
Member Author

pirog commented Dec 14, 2020

@mikemilano i think the interesting wrinkle here will be allowing Lando to override the node command with something that makes more sense for local dev eg switching from pm2 to something like nodemon.

@stale
Copy link

stale bot commented Jun 16, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions and please check out this if you are wondering why we auto close issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants