Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signature pattern failed with Mastodon/Pleroma requests #16

Closed
gudzpoz opened this issue Nov 6, 2020 · 3 comments
Closed

Signature pattern failed with Mastodon/Pleroma requests #16

gudzpoz opened this issue Nov 6, 2020 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@gudzpoz
Copy link
Contributor

gudzpoz commented Nov 6, 2020

The signature field in the request was keyId="https://domain/path#main-key",algorithm="rsa-sha256",headers="(request-target) host date digest content-type",signature="zRbQw......0MUqA==", and I suspect that the algorithm="rsa-sha256" field has caused this problem. (By the way, requests from both Mastodon and Pleroma seem to be using rsa-sha256.)

Can this be fixed somehow? Thanks!

@landrok landrok added the bug Something isn't working label Nov 6, 2020
@landrok landrok self-assigned this Nov 6, 2020
@landrok
Copy link
Owner

landrok commented Nov 6, 2020

Hi, you're true, the algorithm field is not matched by the extraction pattern.

A patch has been applied and packaged with the 0.5.3 release. Can you test it and tell me if it works with your use-case ?

@gudzpoz
Copy link
Contributor Author

gudzpoz commented Nov 6, 2020

The pattern matching still went wrong, but after some testing it seems that it is another issue other than the algorithm field, which has been resolve by your patch.
I've opened pull request #17 and the modification works for me. Would you please check it out?

@gudzpoz gudzpoz closed this as completed Nov 6, 2020
@landrok
Copy link
Owner

landrok commented Nov 6, 2020

Packaged with the 0.5.4 release

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants