Bugfix report different behavior based on path #262
Conversation
Pull Request Test Coverage Report for Build 617
💛 - Coveralls |
|
@chocoelho are you using an automatic formatter? Most of the changes are cosmetic which makes it hard to figure out what actual functionality has changed. I'm all for having a conistent coding style - I'm a big fan of black and there's a pre-commit hook to add to |
|
I've been using YAPF, but I can switch to black if that's preferrable. I've set my editor to format as I touch files, this can be turned off for prospector as well.
|
| @@ -187,7 +188,7 @@ def _find_paths(ignore, curpath, rootpath): | |||
| return files, modules, packages, directories | |||
|
|
|||
|
|
|||
| def find_python(ignores, paths, explicit_file_mode, workdir=None): | |||
| @@ -198,5 +199,5 @@ def find_python(ignores, paths, explicit_file_mode, workdir=None): | |||
| return SingleFiles(paths, workdir or os.getcwd()) | |||
| else: | |||
| assert len(paths) == 1 | |||
| files, modules, directories, packages = _find_paths(ignores, paths[0], paths[0]) | |||
|
I think it'd be best to avoid it because you can't guarantee every person is using the same one and PRs would get very difficult to keep track of. So if you could turn it off then create a PR with just the functional changes that'd be great - otherwise any PR from anyone would conflict in annoying ways! |
prospector/tools/pep8/__init__.py
Outdated
| external_config = conf_path | ||
| break | ||
|
|
||
| # create a list of packages, but don't include packages which are |
|
I'll rebase it with what indeed changed. I touched a some other files while debugging some parts of the code. |
Signed-off-by: Carlos Coêlho <carlospecter@gmail.com>
Signed-off-by: Carlos Coêlho <carlospecter@gmail.com>
Signed-off-by: Carlos Coêlho <carlospecter@gmail.com>
Signed-off-by: Carlos Coêlho <carlospecter@gmail.com>
chocoelho
force-pushed
the
bugfix-report-different-behavior-based-on-path
branch
from
e0394fe
to
44116a0
Compare
|
@carlio updated the PR the needed changes |
…erent-behavior-based-on-path
Signed-off-by: Carlos Coêlho <carlospecter@gmail.com>
Resolves #257.
@carlio this will really need your input on it. To summarize, that was a point where
prospectorwould give different results, this should be fixed. Also,pep8linterwas not using all found files depending on the path it was called.