Bugfix report different behavior based on path

prospector/blender_combinations.yaml

@@ -148,6 +148,7 @@ combinations:
     -   # No exception type(s) specified
         - pylint: bare-except
         - frosted: W101
+        - pep8: E722
 
     -   # Spaces around keyword/paramater equals
         - pep8: E251
@@ -203,4 +204,4 @@ combinations:
 
     -
         - pep257: D103
-        - pylint: missing-docstring
+        - pylint: missing-docstring

prospector/config/__init__.py

@@ -24,11 +24,7 @@ def __init__(self):
 
         self.paths = self._get_work_path(self.config, self.arguments)
         self.explicit_file_mode = all(map(os.path.isfile, self.paths))
-
-        if os.path.isdir(self.paths[0]):
-            self.workdir = self.paths[0]
-        else:
-            self.workdir = os.getcwd()
+        self.workdir = os.getcwd()
 
         self.profile, self.strictness = self._get_profile(self.workdir, self.config)
         self.libraries = self._find_used_libraries(self.config, self.profile)
@@ -61,10 +57,11 @@ def get_output_report(self):
         if self.config.output_format is not None:
             output_report = self.config.output_format
         else:
-            output_report = [(self.profile.output_format, self.profile.output_target or [])]
+            output_report = [(self.profile.output_format, self.profile.output_target)]
 
-        if not all(output_report):
-            output_report = [('grouped', [])]
+        for index, report in enumerate(output_report):
+            if not all(report):
+                output_report[index] = (report[0] or 'grouped', report[1] or [])
 
         return output_report
 

prospector/finder.py

@@ -1,4 +1,6 @@
+# -*- coding: utf-8 -*-
 import os
+
 from prospector.pathutils import is_virtualenv
 
 
@@ -187,7 +189,7 @@ def _find_paths(ignore, curpath, rootpath):
     return files, modules, packages, directories
 
 
-def find_python(ignores, paths, explicit_file_mode, workdir=None):
+def find_python(ignores, paths, explicit_file_mode, workdir=''):
     """
     Returns a FoundFiles class containing a list of files, packages, directories,
     where files are simply all python (.py) files, packages are directories
@@ -198,5 +200,5 @@ def find_python(ignores, paths, explicit_file_mode, workdir=None):
         return SingleFiles(paths, workdir or os.getcwd())
     else:
         assert len(paths) == 1
-        files, modules, directories, packages = _find_paths(ignores, paths[0], paths[0])
-        return FoundFiles(paths[0], files, modules, directories, packages, ignores)
+        files, modules, directories, packages = _find_paths(ignores, paths[0], workdir)
+        return FoundFiles(workdir, files, modules, directories, packages, ignores)

prospector/postfilter.py

@@ -30,7 +30,7 @@ def filter_messages(relative_filepaths, root, messages):
         # first get rid of the pylint informational messages
         relative_message_path = os.path.relpath(message.location.path)
 
-        if message.source == 'pylint' and message.code in ('suppressed-message',):
+        if message.source == 'pylint' and message.code in ('suppressed-message', 'file-ignored',):
             continue
 
         # some files are skipped entirely by messages

prospector/tools/pep8/__init__.py

@@ -120,13 +120,41 @@ def configure(self, prospector_config, found_files):
                             external_config = conf_path
                             break
 
+        # create a list of packages, but don't include packages which are
+        # subpackages of others as checks will be duplicated
+        packages = [
+            os.path.split(p)
+            for p in found_files.iter_package_paths(abspath=False)
+        ]
+        packages.sort(key=len)
+        check_paths = set()
+        for package in packages:
+            package_path = os.path.join(*package)
+            if len(package) == 1:
+                check_paths.add(package_path)
+                continue
+            for i in range(1, len(package)):
+                if os.path.join(*package[:-i]) in check_paths:
+                    break
+            else:
+                check_paths.add(package_path)
+
+        for filepath in found_files.iter_module_paths(abspath=False):
+            package = os.path.dirname(filepath).split(os.path.sep)
+            for i in range(0, len(package)):
+                if os.path.join(*package[:i + 1]) in check_paths:
+                    break
+            else:
+                check_paths.add(filepath)
+
+        check_paths = [found_files.to_absolute_path(p) for p in check_paths]
+
         # Instantiate our custom pep8 checker.
         self.checker = ProspectorStyleGuide(
-            paths=list(found_files.iter_package_paths()),
+            paths=check_paths,
             found_files=found_files,
             config_file=external_config
         )
-
         if not use_config or external_config is None:
             configured_by = None
             # This means that we don't have existing config to use.

tests/finder/test_file_finder.py

@@ -1,16 +1,17 @@
+# -*- coding: utf-8 -*-
 import os
 from unittest import TestCase
+
 from prospector.finder import find_python
 from prospector.pathutils import is_virtualenv
 
 
 class TestSysPath(TestCase):
-
     def _run_test(self, name, expected):
         root = os.path.join(os.path.dirname(__file__), 'testdata', name)
         files = find_python([], [root], explicit_file_mode=False)
 
-        expected = [os.path.join(root, e).rstrip(os.path.sep) for e in expected]
+        expected = [os.path.relpath(os.path.join(root, e).rstrip(os.path.sep)) for e in expected]
         actual = files.get_minimal_syspath()
 
         expected.sort(key=lambda x: len(x))

tox.ini

@@ -7,4 +7,4 @@ skip_missing_interpreters = true
 deps =
     nose
     py27: mock
-commands = nosetests tests
+commands = nosetests tests {posargs}