Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use pathlib.Path on the entire message.location.path #580

Merged
merged 10 commits into from
Feb 15, 2023
Merged

fix: Use pathlib.Path on the entire message.location.path #580

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f570433
fix: Use pathlib.Path on the entire message.location.path
christokur Jan 16, 2023
f9c728e
fix: pathlib.Path already imported explicitly
christokur Jan 16, 2023
9d3d7b0
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 16, 2023
096743c
fix: Remove IDE/ debugger configuration
christokur Jan 16, 2023
8a2147a
chore: Unit test for filter_messages
christokur Jan 18, 2023
311ebaf
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 18, 2023
16804be
fix: remove double assignment
christokur Jan 18, 2023
5e0a5a4
feat: Add negative suppression tests
christokur Jan 18, 2023
7697dac
Merge branch 'PyCQA:master' into master
christokur Jan 25, 2023
02ce7b2
chore: Refactor patches
christokur Feb 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
141 changes: 112 additions & 29 deletions poetry.lock
View file
Open in desktop

Large diffs are not rendered by default.

9 changes: 9 additions & 0 deletions tests/suppression/test_suppression.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,3 +37,12 @@ def test_filter_messages(self):
pros = Prospector(config)
pros.execute()
self.assertEqual(0, pros.summary["message_count"])

def test_filter_messages_negative(self):
workdir = Path(__file__).parent / "testdata/test_filter_messages_negative"
with patch("setoptconf.source.commandline.sys.argv", ["prospector"]):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checkout the tests/utils.py module, patch_execution and patch_cli might do what you need here and might as well reuse it

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@christokur I'm not sure you took carlio's comment into account, could you look into it please ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took it into account yes

with patch("setoptconf.source.commandline.sys.argv", ...

and

with patch("sys.argv",  ...

have different semantics which is why I did not use patch_cli

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok refactored things but be aware that pyupgrade also made changes to how typing is used

config = ProspectorConfig(workdir=workdir)
config.paths = [workdir]
pros = Prospector(config)
pros.execute()
self.assertEqual(5, pros.summary["message_count"])
5 changes: 5 additions & 0 deletions tests/suppression/testdata/test_filter_messages_negative/.prospector.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
output-format: pylint
autodetect: false
strictness: veryhigh
test-warnings: true
doc-warnings: false
6 changes: 6 additions & 0 deletions tests/suppression/testdata/test_filter_messages_negative/ignore_enum.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
from enum import Enum, unique


@unique
class FOO_BAR(Enum):
BAZ = 1
1 change: 1 addition & 0 deletions tests/suppression/testdata/test_filter_messages_negative/ignore_file.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
import collections
3 changes: 3 additions & 0 deletions tests/suppression/testdata/test_filter_messages_negative/ignore_lines.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
import collections
import os
import tempfile