fix: Use pathlib.Path on the entire message.location.path #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
requested changes
Jan 17, 2023
Done. To be fair these tests should have been written when the pathlib refactoring happened. |
for more information, see https://pre-commit.ci
carlio
reviewed
Jan 18, 2023
|
|
||
| def test_filter_messages_negative(self): | ||
| workdir = Path(__file__).parent / "testdata/test_filter_messages_negative" | ||
| with patch("setoptconf.source.commandline.sys.argv", ["prospector"]): |
There was a problem hiding this comment.
Checkout the tests/utils.py module, patch_execution and patch_cli might do what you need here and might as well reuse it
There was a problem hiding this comment.
@christokur I'm not sure you took carlio's comment into account, could you look into it please ?
There was a problem hiding this comment.
I took it into account yes
with patch("setoptconf.source.commandline.sys.argv", ...
and
with patch("sys.argv", ...
have different semantics which is why I did not use patch_cli
There was a problem hiding this comment.
Ok refactored things but be aware that pyupgrade also made changes to how typing is used
Pierre-Sassoulas
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the support for
# noqaDescription
The
postfilter.filter_messagesdoes not recognize the paths from lint messages as matches for ignored paths and messages because it only matches part of the path and uses thestrrepresentation to compare against sets that usepathlib.Pathkeys.Related Issue
#557
Motivation and Context
# noqasupport is broken and users lost the ability to suppress messages since1.8.0How Has This Been Tested?
Use project tests.
Tested against local repo's where the bug is observed using
prospector <= 1.8.4and# noqaworks as expected after the patch.Types of changes
Checklist: