-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Use pathlib.Path on the entire message.location.path #580
Merged
Merged
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
f570433
fix: Use pathlib.Path on the entire message.location.path
christokur f9c728e
fix: pathlib.Path already imported explicitly
christokur 9d3d7b0
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 096743c
fix: Remove IDE/ debugger configuration
christokur 8a2147a
chore: Unit test for filter_messages
christokur 311ebaf
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 16804be
fix: remove double assignment
christokur 5e0a5a4
feat: Add negative suppression tests
christokur 7697dac
Merge branch 'PyCQA:master' into master
christokur 02ce7b2
chore: Refactor patches
christokur File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
tests/suppression/testdata/test_filter_messages/.prospector.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
output-format: pylint | ||
autodetect: false | ||
strictness: veryhigh | ||
test-warnings: true | ||
doc-warnings: false |
6 changes: 6 additions & 0 deletions
6
tests/suppression/testdata/test_filter_messages/ignore_enum.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
from enum import Enum, unique | ||
|
||
|
||
@unique | ||
class FOO_BAR(Enum): # noqa | ||
BAZ = 1 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
import collections # noqa |
3 changes: 3 additions & 0 deletions
3
tests/suppression/testdata/test_filter_messages/ignore_lines.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
import collections # noqa | ||
import os # noqa | ||
import tempfile # noqa |
5 changes: 5 additions & 0 deletions
5
tests/suppression/testdata/test_filter_messages_negative/.prospector.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
output-format: pylint | ||
autodetect: false | ||
strictness: veryhigh | ||
test-warnings: true | ||
doc-warnings: false |
6 changes: 6 additions & 0 deletions
6
tests/suppression/testdata/test_filter_messages_negative/ignore_enum.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
from enum import Enum, unique | ||
|
||
|
||
@unique | ||
class FOO_BAR(Enum): | ||
BAZ = 1 |
1 change: 1 addition & 0 deletions
1
tests/suppression/testdata/test_filter_messages_negative/ignore_file.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
import collections |
3 changes: 3 additions & 0 deletions
3
tests/suppression/testdata/test_filter_messages_negative/ignore_lines.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
import collections | ||
import os | ||
import tempfile |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checkout the
tests/utils.py
module,patch_execution
andpatch_cli
might do what you need here and might as well reuse itThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@christokur I'm not sure you took carlio's comment into account, could you look into it please ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took it into account yes
and
have different semantics which is why I did not use patch_cli
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok refactored things but be aware that pyupgrade also made changes to how typing is used