fix: Use pathlib.Path on the entire message.location.path

prospector/postfilter.py

@@ -1,4 +1,3 @@
-import os
 from pathlib import Path
 from typing import List
 
@@ -30,7 +29,7 @@ def filter_messages(filepaths: List[Path], messages: List[Message]) -> List[Mess
     filtered = []
     for message in messages:
         # first get rid of the pylint informational messages
-        relative_message_path = os.path.relpath(message.location.path)
+        relative_message_path = Path(message.location.path)
 
         if message.source == "pylint" and message.code in (
             "suppressed-message",

tests/suppression/test_suppression.py

@@ -1,6 +1,10 @@
 import os
 import unittest
+from pathlib import Path
+from unittest.mock import patch
 
+from prospector.config import ProspectorConfig
+from prospector.run import Prospector
 from prospector.suppression import get_noqa_suppressions
 
 
@@ -24,3 +28,21 @@ def test_ignore_enum_error(self):
         file_contents = self._get_file_contents("test_ignore_enum/test.py")
         _, lines = get_noqa_suppressions(file_contents)
         self.assertSetEqual({5}, lines)
+
+    def test_filter_messages(self):
+        workdir = Path(__file__).parent / "testdata/test_filter_messages"
+        with patch("setoptconf.source.commandline.sys.argv", ["prospector"]):
+            config = ProspectorConfig(workdir=workdir)
+            config.paths = [workdir]
+            pros = Prospector(config)
+            pros.execute()
+            self.assertEqual(0, pros.summary["message_count"])
+
+    def test_filter_messages_negative(self):
+        workdir = Path(__file__).parent / "testdata/test_filter_messages_negative"
+        with patch("setoptconf.source.commandline.sys.argv", ["prospector"]):
+            config = ProspectorConfig(workdir=workdir)
+            config.paths = [workdir]
+            pros = Prospector(config)
+            pros.execute()
+            self.assertEqual(5, pros.summary["message_count"])

tests/suppression/testdata/test_filter_messages/.prospector.yaml

@@ -0,0 +1,5 @@
+output-format: pylint
+autodetect: false
+strictness: veryhigh
+test-warnings: true
+doc-warnings: false

tests/suppression/testdata/test_filter_messages/ignore_enum.py

@@ -0,0 +1,6 @@
+from enum import Enum, unique
+
+
+@unique
+class FOO_BAR(Enum):  # noqa
+    BAZ = 1

tests/suppression/testdata/test_filter_messages/ignore_file.py

@@ -0,0 +1 @@
+import collections  # noqa

tests/suppression/testdata/test_filter_messages/ignore_lines.py

@@ -0,0 +1,3 @@
+import collections  # noqa
+import os  # noqa
+import tempfile  # noqa

tests/suppression/testdata/test_filter_messages_negative/.prospector.yaml

@@ -0,0 +1,5 @@
+output-format: pylint
+autodetect: false
+strictness: veryhigh
+test-warnings: true
+doc-warnings: false

tests/suppression/testdata/test_filter_messages_negative/ignore_enum.py

@@ -0,0 +1,6 @@
+from enum import Enum, unique
+
+
+@unique
+class FOO_BAR(Enum):
+    BAZ = 1

tests/suppression/testdata/test_filter_messages_negative/ignore_file.py

@@ -0,0 +1 @@
+import collections

tests/suppression/testdata/test_filter_messages_negative/ignore_lines.py

@@ -0,0 +1,3 @@
+import collections
+import os
+import tempfile