Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect inline styling in JSX code example on documentation site #12

Closed
Kori000 opened this issue Aug 30, 2023 · 1 comment · Fixed by #13
Closed

Incorrect inline styling in JSX code example on documentation site #12

Kori000 opened this issue Aug 30, 2023 · 1 comment · Fixed by #13

Comments

@Kori000
Copy link
Contributor

Kori000 commented Aug 30, 2023

Hi, maintainers,

I wanted to report an issue I noticed with one of the code examples shown on your project documentation site.

In the JSX example on Prompt cards for images, the inline styling is incorrectly written. The inline styles should be written as an object, which could cause errors if developers copy the code directly.

For example, in the 'Prompt cards for images' code sample:

// jsx/tsx

<div
  className="h-64 w-full rounded-lg bg-slate-300 bg-cover bg-center shadow-md"
  style="
    background-image: url(https://mpost.io/wp-content/uploads/image-34-32.jpg);
  "
></div>

Should be:

// jsx/tsx

<div
  className="h-64 w-full rounded-lg bg-slate-300 bg-cover bg-center shadow-md"
  style={{
    backgroundImage: 'url(https://mpost.io/wp-content/uploads/image-34-32.jpg)'
  }}
></div>

Regards,
Kori

@ahmadbilaldev
Copy link
Collaborator

Hi @Kori000, thank you for reporting this. I will review your PR and let you know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants